Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit loadNestedJarUri calls to only embedded jar files #7694

Conversation

hayeskl
Copy link

@hayeskl hayeskl commented Jul 14, 2022

Error starting server when BeanDefinitionReference was included from BOOT-INF/classes

jar:file:/Users/khayes/foobar/build/libs/foobar-0.1.jar!/BOOT-INF/classes!/META-INF/micronaut/io.micronaut.inject.BeanDefinitionReference

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2022

CLA assistant check
All committers have signed the CLA.

@hayeskl
Copy link
Author

hayeskl commented Jul 14, 2022

This fixes:
#grails/grails-core#12589

@puneetbehl
Copy link
Contributor

Thank you for the pull request. Please check #7705 which might be a better alternative than checking for .jar.

@puneetbehl puneetbehl requested a review from yawkat July 19, 2022 18:08
@hayeskl
Copy link
Author

hayeskl commented Jul 19, 2022

Confirmed #7705 also fixed my issue.

@yawkat
Copy link
Member

yawkat commented Jul 20, 2022

sorry i didnt see this PR when it was created. superseded by #7705

@yawkat yawkat closed this Jul 20, 2022
@hayeskl hayeskl deleted the feature/fix-embedeed-jar-lookup branch July 20, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants